[webkit-reviews] review requested: [Bug 15765] ASSERTION FAILED: m_frame->page() in FrameLoader::tokenizerProcessedData using the new GMail interface : [Attachment 18170] Remove the two asserts

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 29 10:44:02 PST 2007


Holger Freyther <freyther at handhelds.org> has asked  for review:
Bug 15765: ASSERTION FAILED: m_frame->page() in
FrameLoader::tokenizerProcessedData using the new GMail interface
http://bugs.webkit.org/show_bug.cgi?id=15765

Attachment 18170: Remove the two asserts
http://bugs.webkit.org/attachment.cgi?id=18170&action=edit

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
I know a reduction needs to be done. But here is what is happening:

WebCore::Frame::pageDestroyed() is called because a Frame gets removed from the
FrameSet as the result of JavaScript code. But there were data for the
HTMLTokenizer of the Document and the m_timer was started. The timer fires
after we have removed the Frame from the FrameSet.

FrameLoader::tokenizerProcessedData calls checkCompleted() and checkCompleted()
is checking for if (m_frame->document()) and (m_frame->page()) at various
places and I would argue that removing the asserts is fine as the methods may
return 0 and checkCompleted() will continue to work


More information about the webkit-reviews mailing list