[webkit-reviews] review denied: [Bug 16570] Many toNumber() callers should use a JSValue::getNumber() which ASSERTs instead of branches : [Attachment 18089] Add ASSERTing getNumber and change old getNumber to getNumberOrNaN

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 29 02:38:41 PST 2007


Darin Adler <darin at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 16570: Many toNumber() callers should use a JSValue::getNumber() which
ASSERTs instead of branches
http://bugs.webkit.org/show_bug.cgi?id=16570

Attachment 18089: Add ASSERTing getNumber and change old getNumber to
getNumberOrNaN
http://bugs.webkit.org/attachment.cgi?id=18089&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I think I'll say review- to get this out of the review queue. I had some
critical comments and also there's no change log here.


More information about the webkit-reviews mailing list