[webkit-reviews] review granted: [Bug 16490] ASSERT in ~FrameView while viewing/reloading WICD test case : [Attachment 18131] Balance pauseScheduledEvents() with resumeScheduledEvents()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 27 12:51:08 PST 2007

Eric Seidel <eric at webkit.org> has granted mitz at webkit.org's request for review:
Bug 16490: ASSERT in ~FrameView while viewing/reloading WICD test case

Attachment 18131: Balance pauseScheduledEvents() with resumeScheduledEvents()

------- Additional Comments from Eric Seidel <eric at webkit.org>
This fixes the bug.  I don't like this sort of order-sensitive design however
(completely not your fault).  In the future, I would love to see this code move
to some sort of stack object which would do the pausing for us since all
(except maybe the one which pauses before the timer and resumes after) could
use a stack object instead of manual calls.

Something like:

(awful name, I know)

More information about the webkit-reviews mailing list