[webkit-reviews] review granted: [Bug 15514] <clipPath> with <use> not respected : [Attachment 18107] First attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 25 20:04:40 PST 2007

Eric Seidel <eric at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 15514: <clipPath> with <use> not respected

Attachment 18107: First attempt

------- Additional Comments from Eric Seidel <eric at webkit.org>
A few comments.

1.  You might mention the section of the spec, or even the text, indicating the
direct reference requirement:

14.3.5 Establishing a new clipping path
A 'clipPath' element can contain 'path' elements, 'text' elements, basic shapes
(such as 'circle') or a 'use' element. If a 'use' element is a child of a
'clipPath' element, it must directly reference 'path', 'text' or basic shape

Single line ifs (including those with comments) do no use { } according to the
webkit style guidelines.

Otherwise looks great.	I assume that both test cases show 100x100 green rects
on TOT?

r=me, assuming you fix the spec comment and style issue.

More information about the webkit-reviews mailing list