[webkit-reviews] review requested: [Bug 12526] Safari ignores encoding description "charset=Shift_JIS" in invalid html : [Attachment 18110] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 25 11:00:37 PST 2007

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 12526: Safari ignores encoding description "charset=Shift_JIS" in invalid

Attachment 18110: proposed fix

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This doesn't fix all the examples we have (per comment 3, there are sites that
would require an unacceptably large cut-off), but it fixes quite a few.

I still really dislike the idea that a browser would restart parsing if it sees
a charset declaration anywhere in the document. Hopefully, this brings us close
enough to real world compatibility and we won't have to implement that.

More information about the webkit-reviews mailing list