[webkit-reviews] review requested: [Bug 16570] Many toNumber() callers should use a JSValue::getNumber() which ASSERTs instead of branches : [Attachment 18089] Add ASSERTing getNumber and change old getNumber to getNumberOrNaN

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 16570: Many toNumber() callers should use a JSValue::getNumber() which
ASSERTs instead of branches
http://bugs.webkit.org/show_bug.cgi?id=16570

Attachment 18089: Add ASSERTing getNumber and change old getNumber to
getNumberOrNaN
http://bugs.webkit.org/attachment.cgi?id=18089&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
 JavaScriptCore/API/JSCallbackObjectFunctions.h |    2 +-
 JavaScriptCore/bindings/c/c_utility.cpp	|    2 +-
 JavaScriptCore/kjs/date_object.cpp		|    8 ++++----
 JavaScriptCore/kjs/nodes.cpp			|    4 ++--
 JavaScriptCore/kjs/operations.cpp		|    6 +++---
 JavaScriptCore/kjs/value.cpp			|    8 +++++++-
 JavaScriptCore/kjs/value.h			|   13 ++++++++++---
 7 files changed, 28 insertions(+), 15 deletions(-)