[webkit-reviews] review granted: [Bug 16590] Solaris OS compile fix : [Attachment 18080] Solaris Compile fix from Adrian de Groot

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 23 16:58:45 PST 2007


Eric Seidel <eric at webkit.org> has granted Holger Freyther
<freyther at handhelds.org>'s request for review:
Bug 16590: Solaris OS compile fix
http://bugs.webkit.org/show_bug.cgi?id=16590

Attachment 18080: Solaris Compile fix from Adrian de Groot
http://bugs.webkit.org/attachment.cgi?id=18080&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.  strange that: isinf would use one NaN test and isfinite would use
a different one.  Perhaps we should fix that before landing.  !isNan() is
clearer.


More information about the webkit-reviews mailing list