[webkit-reviews] review granted: [Bug 15382] [CAIRO] Canvas pattern
support : [Attachment 18073] Add canvas pattern support
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 23 16:48:29 PST 2007
Holger Freyther <freyther at handhelds.org> has granted Alp Toker
<alp at atoker.com>'s request for review:
Bug 15382: [CAIRO] Canvas pattern support
http://bugs.webkit.org/show_bug.cgi?id=15382
Attachment 18073: Add canvas pattern support
http://bugs.webkit.org/attachment.cgi?id=18073&action=edit
------- Additional Comments from Holger Freyther <freyther at handhelds.org>
-Try to remove the whitespace change to the RGBA32 lines before landing
-Check for !m_cachedImage->image in CanvasPatern::createPattern
-Free the surface in void CanvasRenderingContext2D::drawImage
-The Image/BitmapImage changes somehow remind me of
nativeImageForCurrentFrame()
More information about the webkit-reviews
mailing list