[webkit-reviews] review cancelled: [Bug 15960] View source mode
displays the attributes after an attribute with an empty
value incorrectly. : [Attachment 18065] Proposed patch v2.1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 23 14:56:52 PST 2007
Anyang Ren <anyang.ren at gmail.com> has cancelled Anyang Ren
<anyang.ren at gmail.com>'s request for review:
Bug 15960: View source mode displays the attributes after an attribute with an
empty value incorrectly.
http://bugs.webkit.org/show_bug.cgi?id=15960
Attachment 18065: Proposed patch v2.1
http://bugs.webkit.org/attachment.cgi?id=18065&action=edit
------- Additional Comments from Anyang Ren <anyang.ren at gmail.com>
I figured out a better fix. It's much easier to determine when
we start processing the next attribute than to determine when we're
done with the current attribute. So whenever we see the guide
character 'a', signaling the beginning of an attribute, we increment
currAttr.
This requires initializing currAttr to -1 so that after the first
increment it starts at 0. So I have to declare currAttr as 'int',
and have to add a static cast to unsigned when I compare it with
token->attrs->length(), an unsigned value.
More information about the webkit-reviews
mailing list