[webkit-reviews] review granted: [Bug 16561] remove debugger overhead from non-debugged JavaScript execution : [Attachment 18038] improved patch; 1.022x as fast SunSpider

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 16561: remove debugger overhead from non-debugged JavaScript execution
http://bugs.webkit.org/show_bug.cgi?id=16561

Attachment 18038: improved patch; 1.022x as fast SunSpider
http://bugs.webkit.org/attachment.cgi?id=18038&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks great.

Two things:
1.  SourceElements::release( needs a better name:
children->release(m_children);
that code makes little sense at first pass.

2nd.  This now changes the behavior of Drosera so that you need to attach
*before* you load a page.  We need to file at least one (possibly two) followup
bugs to this one.
1.  Add the ability walk the tree and swap in/out break nodes for when the
first/last debugger attaches/detaches.
2.  If #1 doesn't get done soon, we'll need to teach Drosera how to recognize
that it's trying to debug a JavaScript page which hasn't been parsed with
debugging information and display a note to the user to reload the scripts (or
just have it reload the scripts automatically)