[webkit-reviews] review denied: [Bug 16478] Redundant isElement checks in NodeLists : [Attachment 17966] Patch. Passes run-webkit-tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 17 14:22:26 PST 2007

Eric Seidel <eric at webkit.org> has denied David Smith <catfish.man at gmail.com>'s
request for review:
Bug 16478: Redundant isElement checks in NodeLists

Attachment 17966: Patch. Passes run-webkit-tests

------- Additional Comments from Eric Seidel <eric at webkit.org>
It makes little sense to me to have an ASSERT for a specific subclass when the
method signature expects the base class.  The better way to change this is to
change the message signature, and then the callers to static_cast when

More information about the webkit-reviews mailing list