[webkit-reviews] review requested: [Bug 16144] [GTK] Clipboard/ selection handling functions : [Attachment 17961] Updated accprding to comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 17 06:22:50 PST 2007


Christian Dywan <christian at twotoasts.de> has asked  for review:
Bug 16144: [GTK] Clipboard/ selection handling functions
http://bugs.webkit.org/show_bug.cgi?id=16144

Attachment 17961: Updated accprding to comments
http://bugs.webkit.org/attachment.cgi?id=17961&action=edit

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
Removed surplus "if (frameData->frame)" checks Holger pointed out.

Using g_signal_emit as suggested by Xan.

Use performDelete() instead of clear().

Added missing documentation.


More information about the webkit-reviews mailing list