[webkit-reviews] review requested: [Bug 13542] gdklauncher doesnt change URL in adress GTKEntry : [Attachment 17936] new patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 16 17:54:31 PST 2007

Maciej Stachowiak <mjs at apple.com> has asked  for review:
Bug 13542: gdklauncher doesnt change URL in adress GTKEntry

Attachment 17936: new patch

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Switching back to review?

alp points out that normal Gtk+ API practice is to return a "const gchar*" and
require the caller to g_strdup the string if it wants to save a copy. In this
case, that would mean caching the value from converting prettyURL() in a
variable in the private struct, as was done before.

More information about the webkit-reviews mailing list