[webkit-reviews] review denied: [Bug 16433] LOW_BANDWIDTH_DISPLAY build is broken : [Attachment 17923] Make LOW_BANDWIDTH_DISPLAY compile

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 16 10:19:16 PST 2007


Darin Adler <darin at apple.com> has denied Grace Kloba <klobag at gmail.com>'s
request for review:
Bug 16433: LOW_BANDWIDTH_DISPLAY build is broken
http://bugs.webkit.org/show_bug.cgi?id=16433

Attachment 17923: Make LOW_BANDWIDTH_DISPLAY compile
http://bugs.webkit.org/attachment.cgi?id=17923&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The rest of the changes look fine, but the change to FrameLoader doesn't seem
to have anything to do with LOW_BANDWIDTH_DISPLAY.

I'm guessing that for some reason Android derives a subclass from FrameLoader.
That doesn't sound like a good idea to me, but also seems unrelated to
LOW_BANDWIDTH_DISPLAY so should not be controlled by the same ifdef.


More information about the webkit-reviews mailing list