[webkit-reviews] review granted: [Bug 14140] REGRESSION: Complex
system KeyBindings don't work properly : [Attachment 17932]
proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 16 09:18:28 PST 2007
Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 14140: REGRESSION: Complex system KeyBindings don't work properly
http://bugs.webkit.org/show_bug.cgi?id=14140
Attachment 17932: proposed fix
http://bugs.webkit.org/attachment.cgi?id=17932&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+ Vector<KeypressCommand>& keypressCommands() { return
m_keypressCommands; }
Even in a case like this, I usually prefer to provide a get/set pair rather
than a single accessor. This allows us to change the set operation to do
additional work without changing all callers, for example.
Change looks good, r=me
More information about the webkit-reviews
mailing list