[webkit-reviews] review granted: [Bug 16454] [GTK] Text input doesn't work consistently on PPC : [Attachment 17918] 0001-Fix-keyval-text-translation-for-key-events-on-big-e.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 16 00:58:09 PST 2007

Alexey Proskuryakov <ap at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 16454: [GTK] Text input doesn't work consistently on PPC

Attachment 17918:

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Per gnome documentation, g_ucs4_to_utf16 signals error by returning NULL -
theoretically, nwc may remain uninitialized in this case, so you shouldn't
compare it to 1.

More importantly, I do not see any reason to truncate the input to "single
character" - probably, the function should be renamed, and then you can just
handle any length (where any is 1 or 2 :) ). Or you can keep the name, and say
that two UTF-16 surrogates are still a single Unicode character.

This is a good fix as is, so r=me, but please consider making it even better!

More information about the webkit-reviews mailing list