[webkit-reviews] review granted: [Bug 16457] Change SymbolTable to use RefPtr<UString::Rep> as its key : [Attachment 17920] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 15 18:14:45 PST 2007

Darin Adler <darin at apple.com> has granted 's request for review:
Bug 16457: Change SymbolTable to use RefPtr<UString::Rep> as its key

Attachment 17920: Patch

------- Additional Comments from Darin Adler <darin at apple.com>
I think that the UString::Rep::nullPtr should probably be a global in
SymbolTable.h and not be a member of UString::Rep rather than in ustring.h.
There's no good reason that class should export a global containing a pointer
to the null rep, and the patch should not have to touch ustring.h/cpp at all.
The only downside I can think of is that you'd have to find a .cpp file to put
the global in.

I also think that the vcproj contains the .h files, and so it should contain
this one too.

You should consider fixing those. Otherwise, r=me.

More information about the webkit-reviews mailing list