[webkit-reviews] review requested: [Bug 16456] Crash in FrameView and other places because ScrollView has Children that were deleted : [Attachment 17919] Crash Fix

[bugzilla-daemon at webkit.org]

Holger Freyther <freyther at handhelds.org> has asked  for review:
Bug 16456: Crash in FrameView and other places because ScrollView has Children
that were deleted
http://bugs.webkit.org/show_bug.cgi?id=16456

Attachment 17919: Crash Fix
http://bugs.webkit.org/attachment.cgi?id=17919&action=edit

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
* The windows port has the ASSERT(!parent()) in the destructor. So I think
adding a removeFromParent call is not an option.
* This fix copies the code from RenderWidget::destroy. We will remove m_widget
from the m_view. For win/gtk/qt it is assumed that m_view == m_widget->parent()
but as the mac doesn't have this method I can't put an assert there.
* Add the ASSERT from the win port to the Qt and Gtk+ one.
* I did not test this patch for regressions yet