[webkit-reviews] review granted: [Bug 16445] Refactor
EventTargetNode & JSEventTargetNode for an upcoming SVG patch
: [Attachment 17917] Updated patch v3
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Dec 15 14:48:11 PST 2007
Eric Seidel <eric at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 16445: Refactor EventTargetNode & JSEventTargetNode for an upcoming SVG
patch
http://bugs.webkit.org/show_bug.cgi?id=16445
Attachment 17917: Updated patch v3
http://bugs.webkit.org/attachment.cgi?id=17917&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good.
+ // Remove existing identical er set with identical arguments.
Still need to do a search for " er" and fix those to " listener". :)
dispatchGenericEvent is horribly long, we'll eventually need to break it up
into more static inlines.
Looks good.
More information about the webkit-reviews
mailing list