[webkit-reviews] review requested: [Bug 16445] Refactor EventTargetNode & JSEventTargetNode for an upcoming SVG patch : [Attachment 17915] Updated patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 15 12:22:17 PST 2007


Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 16445: Refactor EventTargetNode & JSEventTargetNode for an upcoming SVG
patch
http://bugs.webkit.org/show_bug.cgi?id=16445

Attachment 17915: Updated patch v2
http://bugs.webkit.org/attachment.cgi?id=17915&action=edit

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Incorporated Erics suggestions:
- create helper method to convert from JSEventTargetProperties tokens to
AtomicString to simplify getListener/setListener implementation
- Better way to handle s_prototypeName (better, as in actually working
reliable!)

No regressions.


More information about the webkit-reviews mailing list