[webkit-reviews] review requested: [Bug 6129] Incomplete implementation of CSS 2.1 system colors : [Attachment 17908] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 15 02:39:34 PST 2007

Andrew Wellington <proton at wiretapped.net> has asked  for review:
Bug 6129: Incomplete implementation of CSS 2.1 system colors

Attachment 17908: Proposed patch

------- Additional Comments from Andrew Wellington <proton at wiretapped.net>
Use nextafter(256.0, 0.0), fixed the silly rounding issue. Thanks mitz!

Fixed a couple of comments Darin mentioned to be more clear hopeflly.

[NSGraphicsContext saveGraphicsState]; is both necessary and sufficient as far
as my reading of its documentation goes. "saveGraphicsState" is documented as
such: "This method sends the current graphics context a saveGraphicsState
message and pushes the context onto the per-thread stack." To match,
"restoreGraphicsState" does the reverse: "Pops a graphics context from the
per-thread stack, makes it current, and sends the context a
restoreGraphicsState message."

I believe this is necessary (we change the graphics state otherwise), and is
sufficient as we push/pop the appropriate graphics context.

More information about the webkit-reviews mailing list