[webkit-reviews] review granted: [Bug 16420] change regression tests to use document.execCommand instead of textInputController.doCommand : [Attachment 17892] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 16420: change regression tests to use document.execCommand instead of
textInputController.doCommand
http://bugs.webkit.org/show_bug.cgi?id=16420

Attachment 17892: patch
http://bugs.webkit.org/attachment.cgi?id=17892&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

+	 (WebCore::EventHandler::passMouseDownEventToWidget): Removed the
special case code for
+	 NSTextView. This was left over from when we used NSTextField and
NSTextView for form
+	 elements and is no longer used at all.

I think I heard about some plug-ins creating Cocoa views - can this break them?


+static bool verticalScrollDistance(Frame* frame)

This sounds like it should be int.

-if (window.layoutTestController)
-    textInputController.doCommand("selectLine:");
+document.execCommand("SelectLine");

Some of these tests have comments saying that they cannot be run outside DRT -
perhaps these comments should be removed.