[webkit-reviews] review denied: [Bug 16315] FindSafari Needs Path-Only Option : [Attachment 17759] Modification to FindSafari.exe to emit environment information only.

[bugzilla-daemon at webkit.org]

Adam Roben <aroben at apple.com> has denied Brent Fulgham <bfulgham at gmail.com>'s
request for review:
Bug 16315: FindSafari Needs Path-Only Option
http://bugs.webkit.org/show_bug.cgi?id=16315

Attachment 17759: Modification to FindSafari.exe to emit environment
information only.
http://bugs.webkit.org/attachment.cgi?id=17759&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+    if (!printEnvironment)
+    {

Our code style guidelines say that the brace should be on the same line as the
if. See <http://webkit.org/coding/coding-style.html>.

It seems a little strange that if you pass both /printSafariLauncher and
/printSafariEnvironment, you only get the environment and don't get a launcher
at all. Perhaps /printSafariLauncher should override /printSafariEnvironment?

r- so that the above can be considered.