[webkit-reviews] review denied: [Bug 16397] Patch to provide rudimentary JavaScript indentation : [Attachment 17855] Patch to provide rudimentary indentation for JavaScript.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Brent Fulgham
<bfulgham at gmail.com>'s request for review:
Bug 16397: Patch to provide rudimentary JavaScript indentation
http://bugs.webkit.org/show_bug.cgi?id=16397

Attachment 17855: Patch to provide rudimentary indentation for JavaScript.
http://bugs.webkit.org/attachment.cgi?id=17855&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
This patch seems good and is a good step. However, this will break breakpoints.
The line numbers will not match and you will get random breaks that don't match
the original code.

To really fix this we should remember what the original line was and make sure
adding a breakpoint on the "virtual line" really adds a breakpoint for the
original line.

Pretty printing should also be optional, and off by default. We should have a
toolbar button, or something to toggle between pretty print and the original.

Also as mentioned on IRC by bdash, syntax highlighting and pretty printing
should be done in JavaScriptCore. But that can be done later. It would help
speed Drosera up too.

r- until breakpoints work and this is optional.