[webkit-reviews] review denied: [Bug 16406] [Gtk] JavaScriptCore
needs -lpthread : [Attachment 17858] Include -lpthread
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 11 19:50:46 PST 2007
Mark Rowe (bdash) <mrowe at apple.com> has denied 's request for review:
Bug 16406: [Gtk] JavaScriptCore needs -lpthread
http://bugs.webkit.org/show_bug.cgi?id=16406
Attachment 17858: Include -lpthread
http://bugs.webkit.org/attachment.cgi?id=17858&action=edit
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
You should set the review flag to ? if you'd like your patch looked at for
review. You should also include a description of your change in the ChangeLog
at JavaScriptCore/ChangeLog. See http://webkit.org/coding/contributing.html
for more info.
The change looks fine to me. It's not great to always add -lpthread as some
platforms may not use pthreads, but as JavaScriptCore makes the assumption that
they do when building multi-threaded I think it's fine for the meantime.
Marking as r- for now pending a ChangeLog entry. Thanks for the patch!
More information about the webkit-reviews
mailing list