[webkit-reviews] review granted: [Bug 16385] Cleanup kjs_window : [Attachment 17826] First round of cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 10 14:20:56 PST 2007

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 16385: Cleanup kjs_window

Attachment 17826: First round of cleanup

------- Additional Comments from Darin Adler <darin at apple.com>
Please run the sort-Xcode-project-file script on the project file.

+    // - dialogHide: trusted && WindowFeatures::boolFeature(features,
"dialoghide"), makes dialog hide when you print
+    // - help: WindowFeatures::boolFeature(features, "help", true), makes help
icon appear in dialog (what does it do on Windows?)
+    // - unadorned: trusted && WindowFeatures::boolFeature(features,

Seems a little strange here. Global replace problem?

+static bool isSeparator(::UChar c)

I don't think you need the :: here. It was needed because of "using namespace

+    {}

We usually put those braces on separate lines.

Where's the update to the .pro and .bkl files?

Otherwise looks fine.

More information about the webkit-reviews mailing list