[webkit-reviews] review requested: [Bug 15313] Same-origin check wrong when document.domain set : [Attachment 17824] Patch for this issue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 10 12:05:22 PST 2007

Adam Barth <hk9565 at gmail.com> has asked  for review:
Bug 15313: Same-origin check wrong when document.domain set

Attachment 17824: Patch for this issue

------- Additional Comments from Adam Barth <hk9565 at gmail.com>
Here is a patch for this issue.  Hopefully it fixes both the security issue and
the broken tests.  There are two caveats:

1) I can't get the LayoutTests working on my Linux machine, so I haven't been
able to run the patch through the regression suite.

2) I'm not sure how threading works in storage/Database land.  It's possible
the Database object needs to make a copy of the SecurityOrigin instead of just
taking a reference.

More information about the webkit-reviews mailing list