[webkit-reviews] review denied: [Bug 14994] No support for MessageEvent interface : [Attachment 17813] MessageEvent implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 9 21:15:59 PST 2007

Darin Adler <darin at apple.com> has denied Henry Mason <hmason at mac.com>'s request
for review:
Bug 14994: No support for MessageEvent interface

Attachment 17813: MessageEvent implementation

------- Additional Comments from Darin Adler <darin at apple.com>
I'm unclear on the value of having the MessageEvent class without any of the
specific uses of message events. We might not want to add the class until we
have at least one capability that uses these events.

For example, we didn't add TextEvent until we had to code to emit text events.

The code looks good.

Please make a new patch that includes the new files. You'll need to svn add
them and use the svn-create-patch function to make the patch.

We'd also want a test for this. Something simple that creates one of these.

More information about the webkit-reviews mailing list