[webkit-reviews] review requested: [Bug 14651] [CURL] didReceiveResponse() only called for HTTP loads : [Attachment 17792] New attempt that checks a bool value

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 8 15:41:45 PST 2007

Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 14651: [CURL] didReceiveResponse() only called for HTTP loads

Attachment 17792: New attempt that checks a bool value

------- Additional Comments from Kevin Ollivier <kevino at theolliviers.com>
I've updated the implementation to check a bool value before running any of the
local files code. It now no longer runs multiple times during one resource
load, nor will it call CURL APIs, etc. unless necessary.

I added a TODO in the comments about finding a better approach, but so far I've
been unable to find anything in the CURL API that would suggest a better
solution, and the only other way I can see to approach this would be to avoid
CURL entirely for local files, which I think is just going to add to the number
of code paths we need to support. I'd really like to take this route for now so
that we can get the fix in there, as I know it is biting existing wx port users
at least.

More information about the webkit-reviews mailing list