[webkit-reviews] review denied: [Bug 14651] [CURL] didReceiveResponse() only called for HTTP loads : [Attachment 17785] Patch to call didReceiveResponse and set the URL for local files

[bugzilla-daemon at webkit.org]

Alp Toker <alp at atoker.com> has denied Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 14651: [CURL] didReceiveResponse() only called for HTTP loads
http://bugs.webkit.org/show_bug.cgi?id=14651

Attachment 17785: Patch to call didReceiveResponse and set the URL for local
files
http://bugs.webkit.org/attachment.cgi?id=17785&action=edit

------- Additional Comments from Alp Toker <alp at atoker.com>
This bug fix works and is much needed.

I'm concerned about one thing in the implementation though:

writeCallback() is a hot path. We should first research if we can call
didReceiveResponse() earlier than writeCallback(). If this isn't an option, the
didReceiveResponse() call in writeCallback() needs to be made as lightweight as
possible -- perhaps a boolean check, rather than querying CURL for the
effective URL, constructing a KURL and updating the response again and again.
It only needs to be done once, right?

Think you could devise a lighter solution?