[webkit-reviews] review granted: [Bug 15528] svg_dynamic_cast should be removed : [Attachment 17780] First attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 13:55:49 PST 2007

Darin Adler <darin at apple.com> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 15528: svg_dynamic_cast should be removed

Attachment 17780: First attempt

------- Additional Comments from Darin Adler <darin at apple.com>
 918		     if (node && node->isSVGElement())
 919			 textContent =

Why is isSVGElement() sufficient evidence that this is a SVGTextContentElement?
What guarantees that?

 83		target =

Should just use document() here instead of ownerDocument(). ownerDocument() is
a lsower was to do the same thing.

 85		target = parentNode();
8686		 while (target) {
8787		     if (target->nodeType() != ELEMENT_NODE)
8888			 target = target->parentNode();
8989		     else
9090			 break;
9191		 }

This code seems unneeded to me. What node has a parent that's not an element?


More information about the webkit-reviews mailing list