[webkit-reviews] review granted: [Bug 16334] REGRESSION (r28299): Homepage of any DotMac Web Gallery won't load completely : [Attachment 17772] Avoid re-entering scheduleRelayoutOfSubtree()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 10:17:41 PST 2007


Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 16334: REGRESSION (r28299): Homepage of any DotMac Web Gallery won't load
completely
http://bugs.webkit.org/show_bug.cgi?id=16334

Attachment 17772: Avoid re-entering scheduleRelayoutOfSubtree()
http://bugs.webkit.org/attachment.cgi?id=17772&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

I am getting frustrated with the difficulty of understanding things like the
second boolean to setChildNeedsLayout and the various constraints on what is
and is not safe to call. We need to make some progress in clarity in the render
tree code when viewed up close -- ideally we will get to the point where we can
reason about the correctness of a fragment of code without having to constantly
consider the big picture.


More information about the webkit-reviews mailing list