[webkit-reviews] review granted: [Bug 16325] REGRESSION: www.xerox.ru doesn't work : [Attachment 17767] revised fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 7 00:43:45 PST 2007


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 16325: REGRESSION: www.xerox.ru doesn't work
http://bugs.webkit.org/show_bug.cgi?id=16325

Attachment 17767: revised fix
http://bugs.webkit.org/attachment.cgi?id=17767&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Our usual approach with NSUInteger is to define it somewhere inside
BUILDING_ON_TIGER rather than just using unsigned. See
mac/Misc/WebTypesInternal.h for that in WebKit.

Normally we try to avoid autorelease unless we are forced to use it. So we'd
typically use a RetainPtr or plain old retain/release on the NSMutableArray.

r=me


More information about the webkit-reviews mailing list