[webkit-reviews] review granted: [Bug 15669] Build with -DXP_UNIX and -lXt for GTK+/X11 port : [Attachment 17676] remove WebKitTools changes and fix changelog for -lXt removal

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rodney Dawes
<dobey at wayofthemonkey.com>'s request for review:
Bug 15669: Build with -DXP_UNIX and -lXt for GTK+/X11 port
http://bugs.webkit.org/show_bug.cgi?id=15669

Attachment 17676: remove WebKitTools changes and fix changelog for -lXt removal
http://bugs.webkit.org/attachment.cgi?id=17676&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This seems good to me, except that I do not like the name of the new header
file.

I don't think the use of the term "proxy" in the title makes sense, and since
it's an internal file for WebCore, we don't have to use the "np" style naming.

 gtk-port {
+x11:plugins {
+    DEFINES += XP_UNIX
+}
+

Can this be indented so the nesting looks logical? I don't know the syntax of
these files, so I'm not sure.

r=me as-is, though -- those are really quibbles and this code is already pretty
messy