[webkit-reviews] review granted: [Bug 16091] JSCRE needs to import the PCRE test suite : [Attachment 17745] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 6 09:16:24 PST 2007

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 16091: JSCRE needs to import the PCRE test suite

Attachment 17745: proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
Looks great!

What will we do with this going forward, though?

For the many tests that reflect differences between PCRE and desired JavaScript
behavior, will we change the original testinput/output files, or what?

Some of the failures look to me like they might reflect problems in the test
harness, like this one:

+    abcd\t\n\r\f\a\e9;\$\\?caxyz: FAIL. Actual results: "null"


More information about the webkit-reviews mailing list