[webkit-reviews] review granted: [Bug 16091] JSCRE needs to import the PCRE test suite : [Attachment 17745] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 16091: JSCRE needs to import the PCRE test suite
http://bugs.webkit.org/show_bug.cgi?id=16091

Attachment 17745: proposed patch
http://bugs.webkit.org/attachment.cgi?id=17745&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks great!

What will we do with this going forward, though?

For the many tests that reflect differences between PCRE and desired JavaScript
behavior, will we change the original testinput/output files, or what?

Some of the failures look to me like they might reflect problems in the test
harness, like this one:

+/abcd\t\n\r\f\a\e\071\x3b\$\\\?caxyz/
+    abcd\t\n\r\f\a\e9;\$\\?caxyz: FAIL. Actual results: "null"

r=me