[webkit-reviews] review requested: [Bug 16179] any attribute name start with a unicode which like #xx00(x could be any hex number[0-9a-f]) will cause HTMLTokenizer parse error. : [Attachment 17733] patch for fixing this bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 5 18:40:21 PST 2007


johnnyding <johnnyding.webkit at gmail.com> has asked Darin Adler
<darin at apple.com> for review:
Bug 16179: any attribute name start with a unicode which like #xx00(x could be
any hex number[0-9a-f]) will cause HTMLTokenizer parse error.
http://bugs.webkit.org/show_bug.cgi?id=16179

Attachment 17733: patch for fixing this bug
http://bugs.webkit.org/attachment.cgi?id=17733&action=edit

------- Additional Comments from johnnyding <johnnyding.webkit at gmail.com>
Hi Darin. Thanks for your comment. Please have another look of my new patch.

About the performance test. Anything need I add to patch?
Also I think since only ASCII characters can be as entity name, if I use one
stand-alone char buffer to temporarily save and deal with entity name, it
should not effect the performance, right?

Thanks!


More information about the webkit-reviews mailing list