[webkit-reviews] review denied: [Bug 16179] any attribute name start with a unicode which like #xx00(x could be any hex number[0-9a-f]) will cause HTMLTokenizer parse error. : [Attachment 17727] patch for fixing this bug

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied johnnyding
<johnnyding.webkit at gmail.com>'s request for review:
Bug 16179: any attribute name start with a unicode which like #xx00(x could be
any hex number[0-9a-f]) will cause HTMLTokenizer parse error.
http://bugs.webkit.org/show_bug.cgi?id=16179

Attachment 17727: patch for fixing this bug
http://bugs.webkit.org/attachment.cgi?id=17727&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+		     // from statck, its' length is 10, should be OK.

Misspellings here: statck should be stack and its' should be its.

+		     unsigned int testedEntityNameLen = 0;

We normally delcar these as unsigned.

+			 if (cBuffer[testedEntityNameLen] > 0xff)

Seems to me we could use a smaller cutoff. Only ASCII characters can be in the
entity names, so the cutoff could be 7F or 7E.

+			     break;
+			 else
+			     chTmpEntityNameBuffer[testedEntityNameLen] =
cBuffer[testedEntityNameLen];

No need for an else after a break; we don't like to nest code like this.

The layout test should not be in the webarchive directory -- it's not a test of
web archives. It should go into the fast/parser directory since it's a test of
the HTML parser.

Also, the test should use "dumpAsText()" so it can work cross-platform.

Since this is super-hot code, we need to do some performance testing to make
sure it doesn't slow things down.