[webkit-reviews] review denied: [Bug 14809] [gtk] Implement settings as properties of WebKitGtkPage : [Attachment 17679] webkit: set_property and get_property

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 3 10:51:32 PST 2007

Mark Rowe (bdash) <mrowe at apple.com> has denied Salvatore De Paolis
<iwkse at claws-mail.org>'s request for review:
Bug 14809: [gtk] Implement settings as properties of WebKitGtkPage

Attachment 17679: webkit: set_property and get_property

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
I think PROP_IMAGES_LOAD_AUTOMATICALLY and "auto-images-load" should be
PROP_AUTO_LOAD_IMAGES and "auto-load-images" respectively.  "auto-images-load"
doesn't make sense as-is.

The default fonts you have specified, amongst other things, do not appear to
match those used in webkit_web_view_init.  Is there a reason for this?

In webkit_web_view_class_init  there needs to be a blank line before the
property PROP_FONT_SIZE_DEFAULT_FIXED is created to be consistent.

More information about the webkit-reviews mailing list