[webkit-reviews] review requested: [Bug 15561] GTK port needs DumpRenderTree implementation : [Attachment 17641] 0001-First-stub-at-DRT-for-Gtk.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 2 03:39:00 PST 2007

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 15561: GTK port needs DumpRenderTree implementation

Attachment 17641: 0001-First-stub-at-DRT-for-Gtk.patch

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Patch updated to work with trunk.

Few things I had to do (also using WorkQueueItemGtk from Alp):

- Implement get_children and get_inner_text for WebKitWebFrame.
- Make JSStringCopyUTF8CString return something.
- Make ScriptItem::invoke() use script() instead of url()
- Generally update to use new APIs

And probably some other things I forget :)

Have to run now, please have a look at the patch and later I can update a new
version addressing any comment and with ChangeLog etc.

More information about the webkit-reviews mailing list