[webkit-reviews] review cancelled: [Bug 15102] XMLHttpRequests.onreadystatechange and XMLHttpRequests.addEventListener(readystatechange, ...) should have the same behavior : [Attachment 16158] proposed fix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has cancelled Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 15102: XMLHttpRequests.onreadystatechange and
XMLHttpRequests.addEventListener(readystatechange, ...) should have the same
behavior
http://bugs.webkit.org/show_bug.cgi?id=15102

Attachment 16158: proposed fix
http://bugs.webkit.org/attachment.cgi?id=16158&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
(In reply to comment #4)
> It's be better to say evt.release() in the first call to dispatchEvent

  Done.

> If we're going to keep dispatching the same event to multiple objects, should

> stopPropagation on the event make us stop?

My understanding is that stopPropagation() only prevents traversing the DOM
hierarchy, but listeners registered on the same node are invoked anyway. I've
extended the test to check for this - it passes in yesterday's Firefox nightly.