[webkit-reviews] review denied: [Bug 15062] Implement document.compatMode : [Attachment 16147] implementation in the Document interface

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 28 20:50:59 PDT 2007

Sam Weinig <sam at webkit.org> has denied Vincent Ricard <magic at magicninja.org>'s
request for review:
Bug 15062: Implement document.compatMode

Attachment 16147: implementation in the Document interface

------- Additional Comments from Sam Weinig <sam at webkit.org>
The "{" should be on a new line.
+String Document::compatMode() const {
+    return inCompatMode() ? "BackCompat" : "CSS1Compat";

I don't think there is any reason for [ConvertNullStringTo=Undefined] as null
is not a possible return value.
+	 readonly attribute [ConvertNullStringTo=Undefined] DOMString

Also, does this attribute make sense for Documents other HTML documents?  If
not, can we put this in the HTMLDocument?  r- for now.

More information about the webkit-reviews mailing list