[webkit-reviews] review denied: [Bug 14812] [gtk] [request] add webkit_gtk_frame_get_title() function : [Attachment 16044] Updated to trunk and following naming comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 27 03:30:16 PDT 2007

Mark Rowe (bdash) <mrowe at apple.com> has denied Diego Escalante Urrelo
<diegoe at gnome.org>'s request for review:
Bug 14812: [gtk] [request] add webkit_gtk_frame_get_title() function

Attachment 16044: Updated to trunk and following naming comments

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Inside webkit_gtk_frame_title_changed_cb g_strdup is called but I don't see any
corresponding calls to free the memory.

There are some minor coding style issues present:
+webkit_gtk_frame_get_title (WebKitGtkFrame* frame)

should be one line, for example.

You should also include a ChangeLog entry.  You can use
WebKitTools/Scripts/prepare-ChangeLog to generate a template which you can then
fill in.

More information about the webkit-reviews mailing list