[webkit-reviews] review denied: [Bug 15079] Fails to build on arm (debian) : [Attachment 16121] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 26 00:53:13 PDT 2007

Adam Roben <aroben at apple.com> has denied 's request for review:
Bug 15079: Fails to build on arm (debian)

Attachment 16121: Patch

------- Additional Comments from Adam Roben <aroben at apple.com>
Thanks for the patch! A couple of comments.

+#if   defined(arm) \
+   || defined(__arm__)

You should just put these on the same line:

#if defined(arm) || defined(__arm__)

You'll need to create a ChangeLog entry using the prepare-ChangeLog. See

You should also set the review flag to ? when uploading patches so that people
know they need review.

Once you have a patch with a ChangeLog entry, upload it here and I'll r+ it.

More information about the webkit-reviews mailing list