[webkit-reviews] review granted: [Bug 14899] !d->m_view->needsLayout() in Frame::paint() (Causes assert) : [Attachment 16065] Fix one reproducible instance of the ASSERT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 21 14:51:43 PDT 2007

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 14899: !d->m_view->needsLayout() in Frame::paint() (Causes assert)

Attachment 16065: Fix one reproducible instance of the ASSERT

------- Additional Comments from Darin Adler <darin at apple.com>
+    String width = getAttribute(widthAttr);
+    String height = getAttribute(heightAttr);

It'd be slightly more efficient to use const AtomicString& for these. This
would avoid a little bit of reference count churn. If we changed setAttribute
to take const AtomicString& we could also save re-hashing the string values to
make them Atomic again.

But that's very minor and I like the patch as-is.


More information about the webkit-reviews mailing list