[webkit-reviews] review requested: [Bug 14997] Support for server-sent DOM events : [Attachment 16038] Updated Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 20 12:58:20 PDT 2007


Henry Mason <hmason at mac.com> has asked	for review:
Bug 14997: Support for server-sent DOM events
http://bugs.webkit.org/show_bug.cgi?id=14997

Attachment 16038: Updated Patch
http://bugs.webkit.org/attachment.cgi?id=16038&action=edit

------- Additional Comments from Henry Mason <hmason at mac.com>
This patch addresses most of the issues brought up so far, along with some
others:

- More sane use of RefPtr stuff
- Now supports adding an event source directly to a Document without crashing
- EventTargetNode now only stores a pointer to its internal URL->Stream Loader
hash map, thus making nodes which don't need event sources require much less
memory
- Refactored the field parsing code
- Proper handling of split CR+LF packets
- Switched to BSD license for all new code

Is there a fast way to concat strings? The + operator is what's used in KJS's
array join() method...



More information about the webkit-reviews mailing list