[webkit-reviews] review denied: [Bug 6047] :first-line text-decorations are not rendered : [Attachment 15988] Patch to check if the RenderObject is a firstLineBlock

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 6047: :first-line text-decorations are not rendered
http://bugs.webkit.org/show_bug.cgi?id=6047

Attachment 15988: Patch to check if the RenderObject is a firstLineBlock
http://bugs.webkit.org/attachment.cgi?id=15988&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Need a test case that illustrates the problem as part of the patch.

Rename "firstMode" to "firstLine".

You don't need to duplicate all the bit checking.  Just grab the right style
once at the top using style(firstLine).