[webkit-reviews] review granted: [Bug 15008] ASSERTION FAILED: !firstLineBox() == !lastLineBox() setting content on image : [Attachment 16023] Check that the renderer is an image before calling RenderImage methods

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 19 10:44:17 PDT 2007


Adam Roben <aroben at apple.com> has granted mitz at webkit.org's request for review:
Bug 15008: ASSERTION FAILED: !firstLineBox() == !lastLineBox() setting content
on image
http://bugs.webkit.org/show_bug.cgi?id=15008

Attachment 16023: Check that the renderer is an image before calling
RenderImage methods
http://bugs.webkit.org/attachment.cgi?id=16023&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+    if (RenderObject* renderer = element()->renderer()) {
+	 if (renderer->isImage())
+	     static_cast<RenderImage*>(renderer)->resetAnimation();
+    }

The braces here aren't necessary (or anywhere else in the lines you added in
this patch).

r=me



More information about the webkit-reviews mailing list