[webkit-reviews] review requested: [Bug 14967] Reduce wtf::Vector::operator[]() overloads to eliminate compiler warnings on Windows 64-bit : [Attachment 15997] Remove all remaining bits of operator T*

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 18 00:17:24 PDT 2007


Peter Kasting <zerodpx at gmail.com> has asked  for review:
Bug 14967: Reduce wtf::Vector::operator[]() overloads to eliminate compiler
warnings on Windows 64-bit
http://bugs.webkit.org/show_bug.cgi?id=14967

Attachment 15997: Remove all remaining bits of operator T*
http://bugs.webkit.org/attachment.cgi?id=15997&action=edit

------- Additional Comments from Peter Kasting <zerodpx at gmail.com>
I tested on a friend's Mac to ensure that the compile succeeded.  I wasn't
really able to see whether any new warnings were issued.  If someone else could
check that that would be great.  That said, this is how the STL does things, so
I suspect it's OK.

As mentioned previously, I'm having problems getting prepare-ChangeLog to work
for me.  Here's a ChangeLog entry someone landing this patch could use:

patch by Peter Kasting <zerodpx at gmail.org>, reviewed by Sam Weinig
http://bugs.webkit.org/show_bug.cgi?id=14967 part 2 - Eliminate all remaining
implicit conversions of wtf::Vector<T> to T*.  Where code was previously
checking that the Vector's data pointer was non-NULL, check !Vector::isEmpty()
instead.



More information about the webkit-reviews mailing list