[webkit-reviews] review requested: [Bug 6047] :first-line
text-decorations are not rendered : [Attachment 15988] Patch
to check if the RenderObject is a firstLineBlock
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 16 06:40:31 PDT 2007
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked for review:
Bug 6047: :first-line text-decorations are not rendered
http://bugs.webkit.org/show_bug.cgi?id=6047
Attachment 15988: Patch to check if the RenderObject is a firstLineBlock
http://bugs.webkit.org/attachment.cgi?id=15988&action=edit
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Thanks for the patch, Vincent!
Please set the "review?" flag on patches in the future so that they may be
found and reviewed by Bugzilla queries.
I am not qualified to review the correctness of this patch, but you will need
to include a ChangeLog and a layout test with this patch before it lands.
Details are here:
http://webkit.org/coding/contributing.html
More information about the webkit-reviews
mailing list