[webkit-reviews] review denied: [Bug 14112] Cross-port KDE KJS
UnaryPlus and UnaryMinus optimizations : [Attachment 15957]
Revised proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 14 07:57:33 PDT 2007
Darin Adler <darin at apple.com> has denied Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 14112: Cross-port KDE KJS UnaryPlus and UnaryMinus optimizations
http://bugs.webkit.org/show_bug.cgi?id=14112
Attachment 15957: Revised proposed patch
http://bugs.webkit.org/attachment.cgi?id=15957&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
+ if (number->value() < 0.0) {
I think this should be > 0.0 rather than < 0.0.
+ "- - 0",
+ "- - NaN"
I think we need test cases for -1 and for 1.
More information about the webkit-reviews
mailing list